Skip to content

Rename CheckPropertyBelongsToType to CheckContains #32888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Rename CheckPropertyBelongsToType to CheckContains #32888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/EFCore/ChangeTracking/Internal/ArrayPropertyValues.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ public override object? this[string propertyName]
/// </summary>
public override object? this[IProperty property]
{
get => _values[EntityType.CheckPropertyBelongsToType(property).GetIndex()];
set => SetValue(EntityType.CheckPropertyBelongsToType(property).GetIndex(), value);
get => _values[EntityType.CheckContains(property).GetIndex()];
set => SetValue(EntityType.CheckContains(property).GetIndex(), value);
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore/ChangeTracking/Internal/CurrentPropertyValues.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public override TValue GetValue<TValue>(string propertyName)
/// doing so can result in application failures when updating to a new Entity Framework Core release.
/// </summary>
public override TValue GetValue<TValue>(IProperty property)
=> InternalEntry.GetCurrentValue<TValue>(InternalEntry.EntityType.CheckPropertyBelongsToType(property));
=> InternalEntry.GetCurrentValue<TValue>(InternalEntry.EntityType.CheckContains(property));

/// <summary>
/// This is an internal API that supports the Entity Framework Core infrastructure and not subject to
Expand Down
4 changes: 2 additions & 2 deletions src/EFCore/ChangeTracking/Internal/EntryPropertyValues.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ public override object? this[string propertyName]
/// </summary>
public override object? this[IProperty property]
{
get => GetValueInternal(EntityType.CheckPropertyBelongsToType(property));
set => SetValueInternal(EntityType.CheckPropertyBelongsToType(property), value);
get => GetValueInternal(EntityType.CheckContains(property));
set => SetValueInternal(EntityType.CheckContains(property), value);
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore/ChangeTracking/Internal/OriginalPropertyValues.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public override TValue GetValue<TValue>(string propertyName)
/// doing so can result in application failures when updating to a new Entity Framework Core release.
/// </summary>
public override TValue GetValue<TValue>(IProperty property)
=> InternalEntry.GetOriginalValue<TValue>(InternalEntry.EntityType.CheckPropertyBelongsToType(property));
=> InternalEntry.GetOriginalValue<TValue>(InternalEntry.EntityType.CheckContains(property));

/// <summary>
/// This is an internal API that supports the Entity Framework Core infrastructure and not subject to
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore/Metadata/Internal/EntityTypeExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ public static IEnumerable<IReadOnlyNavigation> FindDerivedNavigations(
/// any release. You should only use it directly in your code with extreme caution and knowing that
/// doing so can result in application failures when updating to a new Entity Framework Core release.
/// </summary>
public static IProperty CheckPropertyBelongsToType(
public static IProperty CheckContains(
this IEntityType entityType,
IProperty property)
{
Expand Down