Fix set operation precedence issues #36110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
commented
May 21, 2025
| FROM [Customers] AS [c0] | ||
| WHERE [c0].[City] = N'México D.F.' | ||
| """ | ||
| ( |
There was a problem hiding this comment.
Note that this SQL is slightly worse - we add parentheses although they're not needed. We were already doing this for non-EXCEPT cases (for two heterogeneous set operations). At some point we can improve the parentheses algorithm to more fully eliminate parentheses when they're not needed.
cincuranet
approved these changes
May 22, 2025
roji
changed the title
This was referenced May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36105
Fixes #36112
Thanks to @Charlieface for reporting #36105 and also suggesting the right fix.