Skip to content

Remove obsolete types from Debug/Trace/EventLog types #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 15, 2018
Merged

Remove obsolete types from Debug/Trace/EventLog types #502

merged 5 commits into from
Nov 15, 2018

Conversation

pakrym
Copy link

@pakrym pakrym commented Nov 15, 2018

No description provided.

@pakrym pakrym requested a review from BrennanConroy November 15, 2018 00:20
@pakrym pakrym force-pushed the pakrym/DebugEventTrace branch from 398aac5 to a97be59 Compare November 15, 2018 00:22
@BrennanConroy
Copy link
Member

Fix your compile errors :D

@pakrym pakrym force-pushed the pakrym/DebugEventTrace branch from b98977b to 62fb74d Compare November 15, 2018 19:06
@pakrym pakrym force-pushed the pakrym/DebugEventTrace branch from 2a896e4 to 640d0ae Compare November 15, 2018 23:24
@pakrym pakrym merged commit 678fc58 into master Nov 15, 2018
@poke
Copy link

poke commented Nov 17, 2018

Is there a way we could make the NullScope public again? That’s actually one internal type that I have used in the past since I don’t want to implement a no-op disposable all the time in tests or logger providers that simply don’t have any scopes. Being able to share the same static instance was helpful there (even if it was internal).

@pakrym pakrym deleted the pakrym/DebugEventTrace branch November 19, 2018 21:48
@snakefoot snakefoot mentioned this pull request Dec 5, 2018
Merged
@qub1n
Copy link

qub1n commented Feb 8, 2020

I have update nuget packages in my project and DebugLogger is now internal. What is the recommended replacement?

@BrennanConroy
Copy link
Member

You should be adding debug as a provider in ConfigureLogging or on the logger factory:
https://docs.microsoft.com/aspnet/core/fundamentals/logging/?view=aspnetcore-3.1#add-providers

maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Feb 28, 2020
@pakrym
Remove obsolete types from Debug/Trace/EventLog types (dotnet/extensi…
0f0d249 
…ons#502)

Commit migrated from dotnet/extensions@678fc58
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 2, 2020
@pakrym
Remove obsolete types from Debug/Trace/EventLog types (dotnet/extensi…
c565b67 
…ons#502)

Commit migrated from dotnet/extensions@678fc58
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020
@pakrym
Remove obsolete types from Debug/Trace/EventLog types (dotnet/extensi…
31848dd 
…ons#502)

Commit migrated from dotnet/extensions@678fc58
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 27, 2020
@pakrym
Remove obsolete types from Debug/Trace/EventLog types (dotnet/extensi…
bd2d3b5 
…ons#502)

Commit migrated from dotnet/extensions@678fc58
@ghost ghost locked as resolved and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pakrym @BrennanConroy @poke @qub1n