Skip to content

Add FunctionInvokingChatClient.CurrentContext #5786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2025
Merged

Add FunctionInvokingChatClient.CurrentContext #5786

merged 3 commits into from
Jan 10, 2025

Conversation

MackinnonBuck
Copy link
Member

@MackinnonBuck MackinnonBuck commented Jan 9, 2025 •
edited by dotnet-policy-service bot
Loading

Allows AI functions to access the current FunctionInvokingChatClient.FunctionInvocationContext.

This can be used to access the chat history or terminate the function invocation loop.

Fixes #5705

Microsoft Reviewers: Open in CodeFlow

@MackinnonBuck MackinnonBuck requested a review from a team as a code owner January 9, 2025 23:18
stephentoub
stephentoub approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephentoub stephentoub requested a review from Copilot January 9, 2025 23:23
Copilot
Copilot AI reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs:670

  • Ensure that CurrentContext is reset appropriately after the function invocation to avoid unintended side effects.
CurrentContext = context;

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Caching.Hybrid Line 86 77.82 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=912643&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Caching.Hybrid Line 86 77.7 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=912705&view=codecoverage-tab

@stephentoub stephentoub merged commit e4ebc9e into main Jan 10, 2025
6 checks passed
@stephentoub stephentoub deleted the mbuck/expose-invocation-context branch January 10, 2025 14:06
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2025
@jeffhandley jeffhandley added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@stephentoub stephentoub stephentoub approved these changes

Assignees

@MackinnonBuck MackinnonBuck

Labels
area-ai Microsoft.Extensions.AI libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There doesn't seem to be a way to set the context.Terminate in a AIFunction call
4 participants
@MackinnonBuck @dotnet-comment-bot @stephentoub @jeffhandley