Skip to content

Conversation

RussKie
Copy link
Contributor

@RussKie RussKie commented Mar 5, 2025

Address various build failures observed in the internal CI for the dev branch (e.g., https://dev.azure.com/dnceng/internal/_build/results?buildId=2655494&view=results).

  • Restrict sourceindex only to internal/main
  • Remove duplicate restore/build/publish calls
Microsoft Reviewers: Open in CodeFlow

@RussKie RussKie requested a review from a team as a code owner March 5, 2025 05:15
@RussKie RussKie requested a review from joperezr March 5, 2025 05:15
@RussKie RussKie requested a review from Copilot March 5, 2025 05:15
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR fixes various build failures by restricting the source index to internal main branch builds and removing duplicate restore/build/publish calls.

  • Adds a conditional block in azure-pipelines.yml to enable source indexing only on the main branch.
  • Updates BuildAndTest.yml to remove duplicate publishing during the docs transport package build step.

Reviewed Changes

File Description
azure-pipelines.yml Introduces a conditional for enabling source index based on branch
eng/pipelines/templates/BuildAndTest.yml Removes duplicate publish command and updates the step display name

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

azure-pipelines.yml:117

  • [nitpick] Consider renaming the variable 'enableSourceIndex' to a more conventional form, such as 'sourceIndexEnabled', to improve clarity and consistency.
    - name: enableSourceIndex

eng/pipelines/templates/BuildAndTest.yml:105

  • [nitpick] The updated display name implies a change in functionality by removing the publish step; please ensure that any related documentation or subsequent steps are updated to reflect this change.
      displayName: Pack docs transport package

@RussKie RussKie enabled auto-merge (squash) March 5, 2025 21:25
@RussKie RussKie merged commit 10e6ac2 into dotnet:main Mar 5, 2025
6 checks passed
@RussKie RussKie deleted the fix_ci_build branch March 5, 2025 21:36
@github-actions github-actions bot added the area-ai-eval Microsoft.Extensions.AI.Evaluation and related label Mar 7, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-ai-eval Microsoft.Extensions.AI.Evaluation and related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants