Add DistributedCachingChatClient/EmbeddingGenerator.AdditionalCacheKeyValues #6558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetCacheKey already enabled augmenting the key list, but doing so required deriving a custom caching client. It appears to be a reasonably common thing to want to configure, so exposing it as a property as well. While doing this, I also removed additional per-call allocation coming from GetCacheKey.
stephentoub
requested review from
peterwald,
eiriktsarpalis and
shyamnamboodiripad
stephentoub
changed the title
peterwald
approved these changes
Jul 1, 2025
stephentoub
commented
Jul 1, 2025
src/Libraries/Microsoft.Extensions.AI/ChatCompletion/DistributedCachingChatClient.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI/ChatCompletion/DistributedCachingChatClient.cs
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Jul 1, 2025
This was referenced Jul 21, 2025
Closed
This was referenced Jul 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetCacheKey already enabled augmenting the key list, but doing so required deriving a custom caching client. It appears to be a reasonably common thing to want to configure, so exposing it as a property as well.
While doing this, I also removed additional per-call allocation coming from GetCacheKey.
Closes #6550
Microsoft Reviewers: Open in CodeFlow