Expose M.E.AI.OpenAI input message conversions #6601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally we have helpers that convert from M.E.AI chat messages to the various OpenAI object models. To ease interop when a developer gets M.E.AI messages from another library and then wants to submit them on their own to OpenAI, this just exposes those helpers publicly.
There was a problem hiding this comment.
Pull Request Overview
This PR exposes internal helper methods to convert M.E.AI chat messages into OpenAI SDK types by making them accessible via public extensions and updating existing client implementations.
- Add public extensions
AsOpenAIChatMessagesandAsOpenAIResponseItems - Change
ToOpenAIChatMessagesandToOpenAIResponseItemsfrom private to internal and adjust their signatures - Update
OpenAIChatClientandOpenAIResponseChatClientto use default JSON options and call the new internal methods - Add comprehensive tests for the new extensions; remove a duplicate test file
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/Libraries/Microsoft.Extensions.AI.OpenAI.Tests/OpenAIConversionTests.cs | New tests covering AsOpenAIChatMessages and AsOpenAIResponseItems |
| test/Libraries/Microsoft.Extensions.AI.OpenAI.Tests/OpenAIAIFunctionConversionTests.cs | Removed redundant conversion tests |
| src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIResponseChatClient.cs | Made ToOpenAIResponseItems internal; added pragma for SA1202 |
| src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIClientExtensions.cs | Added AsOpenAIChatMessages & AsOpenAIResponseItems extensions |
| src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIChatClient.cs | Updated ToOpenAIChatMessages signature and removed JSON options parameter |
Comments suppressed due to low confidence (1)
src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIResponseChatClient.cs:20
- [nitpick] Disabling SA1202 suppresses warnings about element ordering; consider reordering members to follow access-order conventions instead of disabling the rule.
#pragma warning disable SA1202 // Elements should be ordered by access
jeffhandley
approved these changes
Jul 11, 2025
jeffhandley
pushed a commit
to jeffhandley/extensions
that referenced
this pull request
Jul 14, 2025
Internally we have helpers that convert from M.E.AI chat messages to the various OpenAI object models. To ease interop when a developer gets M.E.AI messages from another library and then wants to submit them on their own to OpenAI, this just exposes those helpers publicly.
jeffhandley
pushed a commit
that referenced
this pull request
Jul 15, 2025
Internally we have helpers that convert from M.E.AI chat messages to the various OpenAI object models. To ease interop when a developer gets M.E.AI messages from another library and then wants to submit them on their own to OpenAI, this just exposes those helpers publicly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally we have helpers that convert from M.E.AI chat messages to the various OpenAI object models. To ease interop when a developer gets M.E.AI messages from another library and then wants to submit them on their own to OpenAI, this just exposes those helpers publicly.
Microsoft Reviewers: Open in CodeFlow