Skip to content

With FS1182 warnon, underscore code fixes insert two underscores #15620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #15408
psfinaki opened this issue Jul 18, 2023 · 2 comments · Fixed by #15663
Open
Tracked by #15408

With FS1182 warnon, underscore code fixes insert two underscores #15620

psfinaki opened this issue Jul 18, 2023 · 2 comments · Fixed by #15663
Assignees
@psfinaki
Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics Bug Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.
Milestone
Backlog

Comments

@psfinaki
Copy link
Member

psfinaki commented Jul 18, 2023 •
edited
Loading

In particular, "prefix with underscore" and "replace with underscore".

underscores.mp4
@github-actions github-actions bot added this to the Backlog milestone Jul 18, 2023
@psfinaki psfinaki mentioned this issue Jul 18, 2023
Open
85 tasks
@psfinaki psfinaki changed the title "Prefix with underscore" code fix sometimes prefixes 2 underscores With FS1182 warnon, underscore code fixes insert two underscores Jul 18, 2023
@psfinaki psfinaki added the Area-LangService-CodeFixes Code fixes associated with diagnostics label Jul 18, 2023
@psfinaki
Copy link
Member Author

This happens because the diagnostic is produced twice - by the analyzer and by the compiler. Hence the same code fix is applied twice. It's just luck this doesn't provide broken code and only looks weird.

@psfinaki psfinaki mentioned this issue Jul 21, 2023
Merged
@0101 0101 added Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code. and removed Needs-Triage labels Jul 24, 2023
@github-project-automation github-project-automation bot moved this from Not Planned to Done in F# Compiler and Tooling Jul 31, 2023
@psfinaki
Copy link
Member Author

Reopening to fix properly, see this discussion.

@psfinaki psfinaki reopened this Jul 31, 2023
@github-project-automation github-project-automation bot moved this from Done to In Progress in F# Compiler and Tooling Jul 31, 2023
@psfinaki psfinaki self-assigned this Jul 31, 2023
@psfinaki psfinaki modified the milestones: Backlog, August-2023 Jul 31, 2023
@psfinaki psfinaki mentioned this issue Aug 1, 2023
Merged
@psfinaki psfinaki mentioned this issue Sep 4, 2023
Closed
@psfinaki psfinaki modified the milestones: August-2023, September-2023 Sep 7, 2023
@psfinaki psfinaki modified the milestones: September-2023, October-2023 Oct 4, 2023
@psfinaki psfinaki modified the milestones: October-2023, November-2023 Nov 2, 2023
@psfinaki psfinaki modified the milestones: November-2023, Backlog Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psfinaki psfinaki

Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics Bug Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.
Projects
F# Compiler and Tooling
Status: In Progress
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fixing code fixes, part 5 psfinaki/fsharp
2 participants
@0101 @psfinaki