Update Roslyn dependencies, adjust code fixes #15913
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzarytovskii
reviewed
Sep 1, 2023
eng/Version.Details.xml
Outdated
| @@ -6,24 +6,24 @@ | |||
| <Sha>93c23409e630c4f267234540b0e3557b76a53ef4</Sha> | |||
| <SourceBuild RepoName="source-build-reference-packages" ManagedOnly="true" /> | |||
There was a problem hiding this comment.
All updates in this file should be done via darc dependencies, not manually.
|
You probably can reopen my pr against 17.8 branch, and just use it? It has more updates. |
Yes, probably that would be easier. Will do. |
|
Since you're retargeted it to 17.8, you'll need to rebase on it as well, otherwise a bunch of commits from main will get there. |
vzarytovskii
reviewed
Sep 4, 2023
psfinaki
force-pushed
the
codefixes-30
branch
from
8e6d9c2 to
7aac833
Compare
psfinaki
changed the title
|
@vzarytovskii cleaning up my PRs, I'll be closing this one, probably worth planning Roslyn update at some point anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This definitively fixes #15620
Thanks to dotnet/roslyn#69313, we can now streamline things for bulk code fixes.
They now work naturally when diags are produces by both F# and IDE since the diags share the same span.
demo.mp4