Use ConcurrentDictionary for ProvidedTypeContext dictionaries #11841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzarytovskii
approved these changes
Jul 16, 2021
ForNeVeR
reviewed
Oct 23, 2021
| @@ -271,7 +272,7 @@ module internal ExtensionTyping = | |||
| and ProvidedTypeContext = | |||
| | NoEntries | |||
| // The dictionaries are safe because the ProvidedType with the ProvidedTypeContext are only accessed one thread at a time during type-checking. | |||
There was a problem hiding this comment.
This comment should be revised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We host type providers out-of-process and have our implementation for ProvidedType, in which concurrent read-write operations can occur in the ProvidedTypeContext.
This PR fixes data races in the ProvidedTypeContext.