-
Notifications
You must be signed in to change notification settings - Fork 832
VS: QuickInfo description width #14964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This needs finishing the translations etc. but should already work for testing. |
BTW the process of putting together quickinfo content in VS is super convoluted, this should be really mostly delegated to the service. And why is the code in GoToDefinition.fs? |
Ready when green, unless I forgot something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for your questions:
BTW the process of putting together quickinfo content in VS is super convoluted, this should be really mostly delegated to the service.
Agree, this is worth refactoring probably.
And why is the code in GoToDefinition.fs?
Hard to say from the top of my head, also needs an investigation, GoToDefinition seems to be full of terrible code (and most likely, bugs).
vsintegration/src/FSharp.UIResources/QuickInfoOptionControl.xaml
Outdated
Show resolved
Hide resolved
…nto quickinfo-width
…nto quickinfo-width
As for all the boxing in UI code, this can't be helped. WPF is "object oriented" like this. Our OptionPages are strongly typed, so this is safely contained. |
"Object oriented" :) Alright, let it be then. If you feel for it, you can add some tests for the conversion code. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
I would prefer to have the description a lot more explicit about:
|
The first and the last point are already covered. As for the second one, there is not a simple answer and this feature in fact needs an (experimental) label.
OK, I'm waaay out of the loop and I didn't notice VS now (finally) wraps tooltips approximately to the width of the editor. It does not make sense to fight that built-in behavior, the FCS width setting this PR exposes should work fine with it. I'll add a tooltip explaining what it does exactly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah, great idea with the tooltip - this didn't come to me. I wonder how accessible they are but maybe we should add them to other places in the options.
Anyway, thanks! Merging.
Wire up the new width setting (#14891) :
