Reduce the number of captured name resolution environments in unions and records #15549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerams
commented
Jul 4, 2023
|
Can't run the failing test locally because I'm getting Doesn't this look right though?
|
Had a similar issues and I fixed by git cleaning it and then only build the FSharp.Compiler.Service.sln alone without using the build.cmd part . Hope it helps |
kerams
commented
Jul 4, 2023
T-Gro
approved these changes
Jul 4, 2023
Uh. That doesn't sound right. Do you have the specific issue? |
0101
approved these changes
Jul 7, 2023
edgarfgp
approved these changes
Jul 7, 2023
vzarytovskii
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of incrementally inserting an environment for each field/case, we create only one for the entire representation scope as these entities cannot refer to each other.
Also fixes #13076.
Before
After
The difference in
SyntaxTree.fsis 708 vs 1,054.