-
Notifications
You must be signed in to change notification settings - Fork 820
Filter completions for record fields in patterns #15903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
I can work on it if you want to wait a bit here or help me fix the code completion later. |
I reckon that if you manage to return |
So this can be simplified after #15921? |
Should auto-merge when comments are resolved. |
@vzarytovskii If we decide to merge #15921 first, it would be better to double check that this PR doesn't need any updates. |
Fixes #15889.
| { }
and| { f = 1; g }
do not recover gracefully and there is no match clause, let aloneSynPat.Record
. Didn't feel like fixing that here.