-
Notifications
You must be signed in to change notification settings - Fork 822
Add SyntaxVisitorBase tutorial #15938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some tiny wording stuff from me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. Useful for me as well. Thanks!
What I was curious about when working with this myself, was why we have this particular set of methods to override in the SyntaxVisitorBase thing.
For example we have these FSharpFileParseResults where we - as much as I feel understand - basically build contraptions of top of the SyntaxVisitorBase. Like, why isn't there a builtin thing like VisitAnonRecord
or VisitTypeDefinition
?
You know, everything I always wanted to know about SyntaxVisitorBase but was afraid to ask :D
Co-authored-by: dawe <[email protected]> Co-authored-by: Petr <[email protected]>
Thanks for the reviews everyone!
I'm not sure but I think |
Alright, I think it's very helpful as of now, we can later add more tips there :)
Yeah probably we can later add some guidance on when & how to add some stuff to the SyntaxVisitorBase. |
Adds a bit of prose about the
SyntaxVisitorBase
.Since I'm still new to this, I would greatly value feedback from those who have more experience with it.