Skip to content

Fix a bug in the Add Open code fix #15998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Fix a bug in the Add Open code fix #15998

merged 3 commits into from
Sep 19, 2023

Conversation

psfinaki
Copy link
Member

Fixes #15993

Yeah, yet another possible case. As written in the comment, a proper fix is needed, but this is kind of regression so worth addressing now.

@psfinaki psfinaki requested a review from a team as a code owner September 18, 2023 20:57
@psfinaki psfinaki changed the title Fix a bug in an Add Open code fix Fix a bug in the Add Open code fix Sep 18, 2023
@T-Gro T-Gro enabled auto-merge (squash) September 19, 2023 09:19
Copy link
Member

@abonie abonie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo Vlad's comment maybe

@T-Gro T-Gro merged commit c4b56b4 into dotnet:main Sep 19, 2023
@psfinaki psfinaki deleted the codefixes-37 branch September 19, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

AddOpenCodeFixProvider throws for types with attributes in implicit top-level modules
4 participants