Skip to content

Strip TailCallAttribute during trimming #16028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2023
Merged

Strip TailCallAttribute during trimming #16028

merged 1 commit into from
Oct 5, 2023

Conversation

kerams
Copy link
Contributor

@kerams kerams commented Sep 22, 2023

No description provided.

@kerams kerams requested a review from a team as a code owner September 22, 2023 17:22
@KevinRansom
Copy link
Contributor

Do we know that the tailcall attribute is not useful in pre-compiled scenarios?

@kerams
Copy link
Contributor Author

kerams commented Oct 5, 2023 •
edited
Loading

It doesn't seem to be accessed at run time. Neither does LiteralAttribute, which I could also add in this PR. That one is old, however, so it could break existing applications that look for it from user code (i.e. not from FSharp.Core). Not sure why anyone would do it in the first place, but I am also not aware of any .NET/F# guidelines as far as the support of using reflection to look for built-in attributes in trimmed assemblies is concerned.

@psfinaki psfinaki merged commit 91ff67b into dotnet:main Oct 5, 2023
@kerams kerams deleted the patch-1 branch October 5, 2023 15:37
@allisonchou allisonchou mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@psfinaki psfinaki psfinaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kerams @KevinRansom @vzarytovskii @psfinaki