Skip to content

Conversation

KevinRansom
Copy link
Contributor

@KevinRansom KevinRansom commented Jul 19, 2024

Remove unused values from TcGlobals and add a TcGlobals.fsi file. There were quite a few unused values in the TcGlobals file this PR removes them.

TcGlobals is a very widely used bag of values across the compiler. The .fsi file should help the compiler limit the amount of recompilation when editing the tcglobals.fs file.

No_release notes added, because it's a minor implementation detail.

@KevinRansom KevinRansom requested a review from a team as a code owner July 19, 2024 07:47
@KevinRansom KevinRansom marked this pull request as draft July 19, 2024 07:47
Copy link
Contributor

github-actions bot commented Jul 19, 2024

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@KevinRansom KevinRansom changed the title Some tcglobals stuff Remove unused values from TcGlobals Jul 19, 2024
@KevinRansom KevinRansom added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jul 19, 2024
@KevinRansom KevinRansom marked this pull request as ready for review July 22, 2024 19:17
@psfinaki
Copy link
Contributor

@KevinRansom this now probably requires a manual peek after Brian's cleanup here.

@KevinRansom
Copy link
Contributor Author

@KevinRansom this now probably requires a manual peek after Brian's cleanup here.

@psfinaki --- done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants