Skip to content

Conversation

T-Gro
Copy link
Member

@T-Gro T-Gro commented Aug 29, 2024

This changes the default of realSig to be false until #17607 is resolved.
Once a fix for #17607 is in place, it can change the default back to true.

With current state, compiled code could experience performance degradation at runtime.

@T-Gro T-Gro requested a review from a team as a code owner August 29, 2024 08:56
@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Aug 29, 2024
Copy link
Contributor

github-actions bot commented Aug 29, 2024

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@vzarytovskii
Copy link
Member

Thanks, it's crucial we ship no known optimiser degradation. It might be too late for rc1 though, but rc2 should be fine.

@vzarytovskii vzarytovskii enabled auto-merge (squash) August 29, 2024 17:28
@vzarytovskii vzarytovskii merged commit dcf7db7 into main Aug 29, 2024
30 checks passed
@T-Gro T-Gro deleted the T-Gro-patch-realsig-default branch August 30, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants