Skip to content

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Sep 12, 2024

Description

Better ranges for CE let! and use! error reporting. Continuation of #17671

Before

  • let! in an CE builder
Screenshot 2024-09-20 at 11 20 12
  • let! in a query builder
Screenshot 2024-09-20 at 11 20 49
  • use! in an CE builder
Screenshot 2024-09-20 at 11 26 03
  • use! in a query builder
Screenshot 2024-09-20 at 11 28 00

After

  • let! in an CE builder
let run r2 r3 =
    result {
        let! a = r2
        ^^^^
        return! a
    }
  • let! in a query builder
query {
    let! x = failwith ""
    ^^^^
    yield 1
}
  • use! in an CE builder
let run r2 r3 =
    result {
        use! a = r2
        ^^^^
        return! a
    }
  • use! in a query builder
query {
    use! x = failwith ""
    ^^^^
    yield 1
}

Checklist

  • Test cases added
  • Release notes entry updated

Copy link
Contributor

github-actions bot commented Sep 12, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@edgarfgp edgarfgp closed this Sep 19, 2024
@edgarfgp edgarfgp reopened this Sep 19, 2024
@edgarfgp edgarfgp changed the title Better ranges for CE error reporting Better ranges for CE let! and use! error reporting. Sep 19, 2024
@edgarfgp edgarfgp marked this pull request as ready for review September 20, 2024 10:39
@edgarfgp edgarfgp requested a review from a team as a code owner September 20, 2024 10:39
@edgarfgp edgarfgp requested a review from psfinaki September 20, 2024 15:01
@vzarytovskii vzarytovskii enabled auto-merge (squash) September 21, 2024 00:05
Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Edgar, great job as usual :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants