Skip to content

Conversation

psfinaki
Copy link
Contributor

@psfinaki psfinaki commented Sep 24, 2024

Closes #13654

Nunit is dead, long live xUnit!

See comments.


Notice that the total amount of tests displayed in ADO is a bit different. This seems to be due to different interpretations of Xunit's MemberData.

Nunit:
image

Xunit:
image


The tests should be compared within the same adapter, so first of all, a sanity check using VS adapter:
image


Now, let's look at where the numbers differ in the CI:
image

Note these 3 projects are the only ones having MemberData tests.
image

Different UIs (loggers and adapters) count this at different points and in different times.


Take BreakpointResolutionServiceTests for example. This is a MemberData theory with 7 cases.
image

Notice that VS marks this 1 test with 7 outcomes.

Nunit will not show this at all:
image

Unless you search the exact test by name:
image

Xunit shows this even when searching by file name:
image


Now take another MemberData theory, Unmatched parentheses in RemoveUnnecessaryParenthesesTests:

image

This MemberData theory is created via CE and so VS shows this as 14 distinct tests.


Now, Xunit and NUnit ADO UIs imply different numbers here as well. What matter is the number of tests in the internal XML format though, and these are the same, I checked:
image

So this is all a bit complicated but hopefully this makes enough evidence that tests are executed alright.

Copy link
Contributor

✅ No release notes required

@psfinaki psfinaki marked this pull request as ready for review September 25, 2024 16:39
@psfinaki psfinaki requested a review from a team as a code owner September 25, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Chore: consolidate test frameworks
3 participants