Skip signing VisualFsharp.sln and FSharp.sln when building with .NET … #18113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
|
Marking this as ready for review. This change is needed to unblock dotnet/sdk#44855. Depending on the feedback to #18112 (comment), I'm happy to either revise this PR or open a follow up PR later. |
|
@dotnet/fsharp-team-msft - friendly ping. Can I please get eyes on this? It's needed to enable signing in the VMR for the unified build project. |
mmitche
reviewed
Dec 11, 2024
mmitche
approved these changes
Dec 11, 2024
psfinaki
previously approved these changes
Dec 12, 2024
|
@ellahathaway sorry for the delay. We are waiting for @KevinRansom to take a look at this as he's most knowledgeable in the topic. If this is in a hurry && low risk, we can probably merge it as is and hope things work out. Letting @T-Gro to decide tho. |
KevinRansom
approved these changes
Dec 12, 2024
|
@ellahathaway sorry for the delay I was in England. But now Jet-lag has my attention. |
This was referenced Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18112
May need to be adjusted based on #18112 (comment)
When
VisualFSharp.slnandFSharp.slnare built with .NET Core MSBuild, no artifacts are built that can be signed -> signing fails when an emptyItemsToSignlist.This PR includes a change that sets
-signto false when buildingVisualFSharp.slnorFSharp.slnwith .NET Core on windows.