Skip to content

Make unused bindings an error #18421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 31, 2025
Merged

Make unused bindings an error #18421

merged 12 commits into from
Mar 31, 2025

Conversation

T-Gro
Copy link
Member

@T-Gro T-Gro commented Mar 27, 2025

No description provided.

@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Mar 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-Gro T-Gro marked this pull request as ready for review March 31, 2025 11:10
@T-Gro T-Gro requested a review from a team as a code owner March 31, 2025 11:10
@T-Gro T-Gro enabled auto-merge (squash) March 31, 2025 11:13
psfinaki
psfinaki reviewed Mar 31, 2025
View reviewed changes
@T-Gro T-Gro merged commit 1595946 into main Mar 31, 2025
33 checks passed
@T-Gro T-Gro deleted the re-enable-unused-bindings-warning branch March 31, 2025 13:26
@abonie abonie mentioned this pull request Mar 31, 2025
Closed
This was referenced May 15, 2025
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Jun 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abonie abonie abonie approved these changes

+1 more reviewer

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@T-Gro @psfinaki @abonie