Skip to content

Expand docstring on SynModuleDecl.Types #18698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 20, 2025
Merged

Expand docstring on SynModuleDecl.Types #18698

merged 4 commits into from
Jun 20, 2025

Conversation

Smaug123
Copy link
Contributor

Description

Expand the ambiguous docstring on SynModuleDecl.Types.

This change is in src/Compiler, but I really don't think it merits a release note.

Correctness: the only construction of this DU case is in the fsyacc parser, and if you can decipher that then you're better than I am. But I did check with the Fantomas tools.

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@Smaug123 Smaug123 requested a review from a team as a code owner June 17, 2025 22:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

Martin521
Martin521 reviewed Jun 18, 2025
View reviewed changes
Copy link
Contributor

@Martin521 Martin521 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. I would keep it concise though.
"Type Definition Group" is the term used in the spec.

@edgarfgp edgarfgp added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jun 18, 2025
@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Jun 19, 2025
@T-Gro T-Gro enabled auto-merge (squash) June 19, 2025 12:30
@T-Gro T-Gro merged commit 03712ec into dotnet:main Jun 20, 2025
39 checks passed
T-Gro added a commit that referenced this pull request Jun 24, 2025
@T-Gro @edgarfgp
@dotnet-maestro @Smaug123 @abonie @Copilot
[automated] Merge branch 'main' => 'release/dev18.0' (#18711)
44a24dc 
* More test for error recovery  (#18669)

* [main] Update dependencies from dnceng/internal/dotnet-optimization (#18683)

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20250610.1

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime
 From Version 1.0.0-prerelease.25309.1 -> To Version 1.0.0-prerelease.25310.1

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20250611.1

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime
 From Version 1.0.0-prerelease.25309.1 -> To Version 1.0.0-prerelease.25311.1

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20250616.1

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime
 From Version 1.0.0-prerelease.25309.1 -> To Version 1.0.0-prerelease.25316.1

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20250617.1

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime
 From Version 1.0.0-prerelease.25309.1 -> To Version 1.0.0-prerelease.25317.1

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tomas Grosup <[email protected]>

* [main] Update dependencies from dotnet/arcade (#18643)

* Expand docstring on SynModuleDecl.Types (#18698)

* Update dependencies from https://github.com/dotnet/arcade build 20250620.5 (#18703)

Microsoft.DotNet.Arcade.Sdk
 From Version 10.0.0-beta.25316.2 -> To Version 10.0.0-beta.25320.5

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* Remove feature/lsp merge from branch-merge.yml (#18705)

Cleaning up, sicne we've merged feature/lsp to main some time ago

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20250623.1 (#18710)

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime
 From Version 1.0.0-prerelease.25317.1 -> To Version 1.0.0-prerelease.25323.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* Update dependencies from https://github.com/dotnet/arcade build 20250623.3 (#18709)

Microsoft.DotNet.Arcade.Sdk
 From Version 10.0.0-beta.25320.5 -> To Version 10.0.0-beta.25323.3

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* Remove ActivityDisposable conditional directives and replace with System.IDisposable | null (#18707)

---------

Co-authored-by: Edgar Gonzalez <[email protected]>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tomas Grosup <[email protected]>
Co-authored-by: Patrick Stevens <[email protected]>
Co-authored-by: Adam Boniecki <[email protected]>
Co-authored-by: Copilot <[email protected]>
@dotnet-bot dotnet-bot mentioned this pull request Jul 26, 2025
Open
@dotnet-bot dotnet-bot mentioned this pull request Aug 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@Martin521 Martin521 Martin521 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Smaug123 @Martin521 @T-Gro @edgarfgp