Improve composability of verifyBaseline verifyILBaseline #18777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
T-Gro
reviewed
Jul 25, 2025
T-Gro
reviewed
Jul 25, 2025
T-Gro
approved these changes
Jul 25, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
This was referenced Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan on seeing what can be done to ensure that fsharp compiler emits ILVerifier clean code. In order to ensure that testing is in a good spot. I have made a few tweaks to the test framework wrt to verifyingIL and compiler results.
Specifically verifyILBaseline and verifyBaseline are specified before compilation in the test cases and cause additional runs of the typechecker.
With this change they operate on CompilationResult and compose properly. And I renamed withIlContains to VerifyILContains for a sort of consistency.