Ensure test console always works in VS test explorer #18836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, 36 minutes. this is the fastest run I've ever seen here |
abonie
approved these changes
Aug 11, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
✅ No release notes required |
T-Gro
approved these changes
Aug 12, 2025
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
This was referenced Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the testhost fails catastrophically when executing some selected tests with "run until failure" in VS.
The reason is that apparently VS can keep alive the testhost and execute xUnit's
CreateExecutorandRunTestCasesmany times, but we did some one-time initialisation there. In effect TestConsole redirectors returned null, bringing everything down.This moves the initialization again to a safer place. Also adds some defenses to never return null when a redirected stream is expected.