Trigger add open for FS0043 #2474
Conversation
|
Pretty cool :) |
|
Did you intend to change System.ValueTuple.dll in this PR? |
|
@smoothdeveloper No...hmmm. Maybe that's because I ran |
|
Rebased that change away. I think I used |
| @@ -133,6 +133,7 @@ type internal FSharpAddOpenCodeFixProvider | |||
|
|
|||
| let quilifySymbolFixes = | |||
| candidates | |||
| |> Seq.filter (fun (entity,_) -> not(entity.FullRelativeName.Contains("op_"))) // Don't include fully-qualified operator names. The resultant suggestion makes the code not compile. | |||
There was a problem hiding this comment.
maybe StartsWith? Is there another way we can verify this is an actual operator?
There was a problem hiding this comment.
Modified. I'm not aware of another way (although I imagine there's something in the language service which we could use).
| @@ -133,6 +133,7 @@ type internal FSharpAddOpenCodeFixProvider | |||
|
|
|||
| let quilifySymbolFixes = | |||
There was a problem hiding this comment.
time to fix that typo :)
| @@ -133,6 +133,7 @@ type internal FSharpAddOpenCodeFixProvider | |||
|
|
|||
| let quilifySymbolFixes = | |||
There was a problem hiding this comment.
time to fix that typo :)
|
omg I'm bad at git and comitted the freaking binary again |
| candidates | ||
| |> Seq.filter (fun (entity,_) -> not(entity.FullRelativeName.StartsWith("op_"))) // Don't include qualified operator names. The resultant codefix won't compile because it won't be an infix operator anymore. |
There was a problem hiding this comment.
FullRelativeName can be "M.N.op_xxx", so this filtering won't work for those.
There was a problem hiding this comment.
There was a problem hiding this comment.
Can we somehow say StartsWith "op_" || Contains ".op_"?
I'm not at ease with idea of removing the quick fix for members containing op_ to not work.
Right now in VS2015:
If there is a way to figure that out without string, that would be best but I guess for now we can have that enhanced condition.
fixed: AddOpenCodeFixProvider may suggest name qualifying for operators
|
It works perfectly thanks to @vasily-kirichenko's commit. Ready for merge! |
|
My cat isn't letting me GitHub efficiently |
* Trigger add open for FS0043 * Contains -> StartsWith * fixed: AddOpenCodeFixProvider may suggest name qualifying for operators
I'm not sure if this is a good solution, but this does fix #2473. I can now do a full Suave app by using codefixes with this change: