[RFC FS-1003] Nameof operator redux #6809

dsyme · 2019-05-22T11:05:27Z

Continuation of #6325

Brings #2290 up-to-date with master

Implementation of RFC FS-1003

Testing verified:

Feature limitation:

the feature will not work with type arguments, let f<'t> (x : 't) = nameof 't

…iteral>)`

Conflicts: src/fsharp/FSComp.txt src/fsharp/FSharp.Core.Unittests/SurfaceArea.Silverlight.2.0.fs src/fsharp/FSharp.Core.Unittests/SurfaceArea.net20.fs src/fsharp/PostInferenceChecks.fs src/fsharp/TastOps.fs src/fsharp/TcGlobals.fs

This reverts commit 529cc6f.

This reverts commit 223d313. Conflicts: tests/fsharpqa/Source/Conformance/Expressions/DataExpressions/NameOf/E_NameOfAdditionExpr.fs tests/fsharpqa/Source/Conformance/Expressions/DataExpressions/NameOf/E_NameOfAppliedFunction.fs tests/fsharpqa/Source/Conformance/Expressions/DataExpressions/NameOf/E_NameOfAsAFunction.fs tests/fsharpqa/Source/Conformance/Expressions/DataExpressions/NameOf/E_NameOfDictLookup.fs tests/fsharpqa/Source/Conformance/Expressions/DataExpressions/NameOf/E_NameOfIntConst.fs tests/fsharpqa/Source/Conformance/Expressions/DataExpressions/NameOf/E_NameOfIntegerAppliedFunction.fs tests/fsharpqa/Source/Conformance/Expressions/DataExpressions/NameOf/E_NameOfParameterAppliedFunction.fs tests/fsharpqa/Source/Conformance/Expressions/DataExpressions/NameOf/E_NameOfPartiallyAppliedFunction.fs tests/fsharpqa/Source/Conformance/Expressions/DataExpressions/NameOf/E_NameOfStringConst.fs tests/fsharpqa/Source/Conformance/Expressions/DataExpressions/NameOf/E_NameOfWithPipe.fs

it raises a proper error if applicated to non (Long)Ident arg

remove `typenameof and its tests

This reverts commit a732de0.

…hing to it.

…der to not loose its FSharpSymbolUse

… nameof-operator

KevinRansom · 2019-06-18T09:08:57Z

@cartermp on it

cartermp

After chatting with @TIHan we should remove all baseline-style tests and move these to FSharp.Compiler.UnitTests. We can handle this on our end.

dsyme · 2019-07-03T16:00:20Z

@KevinRansom What's the status of getting this updated with the language version flag checks please? I thought I saw you doing some work on this but I can't find it anywhere.

If you are doing something, please make it a PR to the feature/nameof branch?

KevinRansom · 2019-07-03T21:00:00Z

I am happy to merge this and then add the languageversion into release/fsharp47. That would be a better way of dealing with these language features.

Outdated

KevinRansom · 2019-07-03T22:02:30Z

Almost squashed it .... merging :-)

cmeeren · 2019-08-08T07:10:09Z

Sorry if this is the wrong place to ask, but is it intended to be possible (like in C#) to get the name of an instance member without an instance, e.g. nameof SomeType.InstanceProperty? I installed FSharp.Core 4.7 to test this, but currently compilation fails with Property 'InstanceProperty' is not static. I'm using VS 16.2.1 if that's relevant; do I perhaps need to wait for 16.3?

cartermp · 2019-08-08T19:15:00Z

@cmeeren That's for @dsyme to answer. But since it's not supported, the answer is "no" for now.

cartermp · 2019-08-08T19:25:15Z

It's also worth noting that what is allowable in C# for nameof is adjusted compared to normal statements. SomeType.InstanceProperty is not allowable outside of a nameof() expression. A similar kind of relaxation could be built for F#, but that doesn't exist today.

TIHan · 2019-08-09T01:33:49Z

src/fsharp/FSharp.Core/prim-types.fs

@@ -4142,6 +4142,9 @@ namespace Microsoft.FSharp.Core
        [<CompiledName("TypeOf")>]
        let inline typeof<'T> = BasicInlinedOperations.typeof<'T>

+        [<CompiledName("NameOf")>]
+        let inline nameof (_: 'T) : string = raise (Exception "may not call directly, should always be optimized away")


I feel like we could make this have NoDynamicInvocation

I think it's not needed because the compiler knows of the special rules for this library identifier

TIHan · 2019-08-09T02:47:55Z

tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Core/NameOfTests.fs

+
+    [<Test>]
+    member this.``lookup name of |> operator`` () =
+        let a = nameof(|>)


Do we really want to allow nameof to get the actual names of the operators?

Yes I'm fine with this

dsyme · 2019-08-16T12:24:09Z

@cmeeren That's for @dsyme to answer. But since it's not supported, the answer is "no" for now.

Yes the answer is "no" for now, though it would be good to find a way to support this as we take the feature out of preview

Vasily Kirichenko and others added 30 commits January 18, 2017 16:24

substitute 'nameof(<long ident>) with Conts(<long ident as string l…

d380a0e

…iteral>)`

Implementing basic nameof and typenameof operators

223d313

Conflicts: src/fsharp/FSComp.txt src/fsharp/FSharp.Core.Unittests/SurfaceArea.Silverlight.2.0.fs src/fsharp/FSharp.Core.Unittests/SurfaceArea.net20.fs src/fsharp/PostInferenceChecks.fs src/fsharp/TastOps.fs src/fsharp/TcGlobals.fs

Apply feedback

529cc6f

Revert "Apply feedback"

f3c4ba5

This reverts commit 529cc6f.

revert nameof and typenameof functions to FSharp.Core

77c8f77

wip

3070c1d

it works

b3e712d

Merge remote-tracking branch 'origin/master' into nameof-operator

6c6e3b5

refactoring

7832be5

make it work on simple Idents

6581790

it raises a proper error if applicated to non (Long)Ident arg

use proper error message

0f5165f

restrict using nameof operator as first class

22898ad

remove typenameof bits

e5033af

nameof(typeof<_>) works

1ad0a0e

remove `typenameof and its tests

Merge branch 'master' into nameof-operator

c9a64b2

fix QA tests

5657759

Merge branch 'master' into nameof-operator

b26994c

remove nameof function form FSharp.Core

a732de0

Merge remote-tracking branch 'origin/master' into nameof-operator

b29fe57

Revert "remove nameof function form FSharp.Core"

b7763a6

This reverts commit a732de0.

Try to resolve the nameof operator argument to prevent passing anyt…

906a934

…hing to it.

nameof works on generic types

a770e3c

fix error range in case of wrong nameofoperator argument

067955a

notify name resolution sink about nameof operator argument Item in or…

bfcc390

…der to not loose its FSharpSymbolUse

fully type check nameof argument

6a92a80

try to type check arg again

bcec600

Merge remote-tracking branch 'origin/master' into nameof-operator

f64b3c5

type check nameof argument more carefully

0c1cad2

Merge remote-tracking branch 'vasily-kirichenko/nameof-operator' into…

15bf862

… nameof-operator

merge

a3287ce

KevinRansom force-pushed the feature/nameof branch from 3130685 to a3287ce Compare June 18, 2019 06:01

KevinRansom added 2 commits June 18, 2019 08:20

merge

31bbe42

tweaks

5200435

KevinRansom added 2 commits June 18, 2019 10:37

Merge branch 'release/fsharp47' into feature/nameof

7c9bfe5

restore

e95cf67

cartermp previously requested changes Jun 18, 2019

View reviewed changes

Merge branch 'release/fsharp47' into feature/nameof

77121fd

KevinRansom closed this Jul 2, 2019

KevinRansom reopened this Jul 2, 2019

KevinRansom merged commit 92e4a52 into release/fsharp47 Jul 3, 2019

KevinRansom deleted the feature/nameof branch July 10, 2019 21:54

cartermp modified the milestones: .NET Core 3.0, 16.3 Aug 5, 2019

TIHan reviewed Aug 9, 2019

View reviewed changes

cartermp modified the milestones: 16.3, Unknown / not bug Aug 14, 2019

cmeeren mentioned this pull request Oct 14, 2019

[Question] Use a strongly typed ViewModel elmish/Elmish.WPF#13

Closed

cartermp modified the milestones: Unknown / not bug, 16.5 Jan 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[RFC FS-1003] Nameof operator redux #6809

[RFC FS-1003] Nameof operator redux #6809

Uh oh!

dsyme commented May 22, 2019 •

edited

Loading

Uh oh!

KevinRansom commented Jun 18, 2019

Uh oh!

cartermp left a comment

Uh oh!

dsyme commented Jul 3, 2019

Uh oh!

KevinRansom commented Jul 3, 2019

Uh oh!

KevinRansom commented Jul 3, 2019

Uh oh!

cmeeren commented Aug 8, 2019 •

edited

Loading

Uh oh!

cartermp commented Aug 8, 2019

Uh oh!

cartermp commented Aug 8, 2019

Uh oh!

TIHan Aug 9, 2019 •

edited

Loading

Uh oh!

dsyme Aug 16, 2019

Uh oh!

TIHan Aug 9, 2019 •

edited

Loading

Uh oh!

dsyme Aug 16, 2019

Uh oh!

dsyme commented Aug 16, 2019

Uh oh!

Uh oh!

[RFC FS-1003] Nameof operator redux #6809

[RFC FS-1003] Nameof operator redux #6809

Uh oh!

Conversation

dsyme commented May 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KevinRansom commented Jun 18, 2019

Uh oh!

cartermp left a comment

Choose a reason for hiding this comment

Uh oh!

dsyme commented Jul 3, 2019

Uh oh!

KevinRansom commented Jul 3, 2019

Uh oh!

KevinRansom commented Jul 3, 2019

Uh oh!

cmeeren commented Aug 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cartermp commented Aug 8, 2019

Uh oh!

cartermp commented Aug 8, 2019

Uh oh!

TIHan Aug 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsyme Aug 16, 2019

Choose a reason for hiding this comment

Uh oh!

TIHan Aug 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsyme Aug 16, 2019

Choose a reason for hiding this comment

Uh oh!

dsyme commented Aug 16, 2019

Uh oh!

Uh oh!

dsyme commented May 22, 2019 •

edited

Loading

cmeeren commented Aug 8, 2019 •

edited

Loading

TIHan Aug 9, 2019 •

edited

Loading

TIHan Aug 9, 2019 •

edited

Loading