-
Notifications
You must be signed in to change notification settings - Fork 440
Merge 2.2 changes from dotnet/cli #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update branding for release/2.2.1xx preview3
…rence-versions Add ImplicitPackageReferenceVersion items to bundled versions file
This commit implements the `dotnet list package` command.
This commit implements the requested changes from the PR code review. - Remove unnecessary comments - Use Directory.Exists rather than getting file attributes - Use GracefulException where appripriate - Improve test names and fix spacing - Don't force trailing slash on directory - Don't use option forwarding - Delete unnecessary MSBuild.exe[.config] files from test project - Use forwarded options
Dotnet list package command
…t-versions Insert SDK with implicit ASP.NET versions, add test coverage
…, coresetup, coresetup, coresetup, sdk, templating, templating, websdk to preview3-35364, preview3-35364, preview3-35364, preview3-35364, preview3-35364, preview3-35364, preview3-35364, preview3-35364, preview3-27001-02, preview3-27001-02, preview3-27001-02, preview3-63401-01, beta4-20180930-2076037, beta4-20180930-2076037, preview3-20180930-2076033, respectively
Add the Razor SDK to the versions to update
…x-UpdateDependencies Update aspnet, aspnet, aspnet, aspnet, aspnet, aspnet, aspnet, aspnet, coresetup, coresetup, coresetup, sdk, templating, templating, websdk to preview3-35364, preview3-35364, preview3-35364, preview3-35364, preview3-35364, preview3-35364, preview3-35364, preview3-35364, preview3-27001-02, preview3-27001-02, preview3-27001-02, preview3-63401-01, beta4-20180930-2076037, beta4-20180930-2076037, preview3-20180930-2076033, respectively (release/2.2.1xx)
Ubuntu.18.04 leg failed with:
https://ci.dot.net/job/dotnet_core-sdk/job/master/job/debug_ubuntu.18.04_x64_prtest/203/ |
@dotnet-bot test ubuntu.18.04 x64 Debug Build |
livarcocc
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among other things, this includes updates to the bundled versions to support implicit ASP.NET Core versions.