[Java.Interop] Remove support for NewObjectRequired #1247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: 972c5bc Context: dotnet/android#9146 As our minimum Android API level is now API-21 (Android 5.0), and .NET for Android only sets `Java.Interop.JniRuntime.CreationOptions.NewObjectRequired`=true on API-10 and lower, we can remove the support for this option. This has the added benefit of removing the TLS lookup that `JniEnvironment.Runtime` requires, and thus *should* improve perf. Add `[Obsolete]` to `JniRuntime.CreationOptions.NewObjectRequired`.
jonpryor
force-pushed
the
dev/jonp/jonp-remove-NewObjectRequired
branch
from
c0a4085 to
f3acbe7
Compare
jonathanpeppers
approved these changes
Aug 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: 972c5bc
Context: dotnet/android#9146
As our minimum Android API level is now API-21 (Android 5.0), and .NET for Android only sets
Java.Interop.JniRuntime.CreationOptions.NewObjectRequired=true on API-10 and lower, we can remove the support for this option. This has the added benefit of removing the TLS lookup thatJniEnvironment.Runtimerequires, and thus should improve perf.Add
[Obsolete]toJniRuntime.CreationOptions.NewObjectRequired.