[generator] Don't mark a method as [UnsupportedOSPlatform]
if it overrides a supported base method.
#1313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #1307
Context:
While technically correct that
android.os.Bundle.putString (...)
was "removed" in API-21, it was really moved to a base class asandroid.os.BaseBundle.putString (...)
. We will continue to generate both methods for binary compatibility, but we should not mark the override method as[UnsupportedOSPlatform]
because the "supported" base method is still present.Fix
generator
to recognize this case and not emit[UnsupportedOSPlatform]
here.With this change,
Android.OS.Bundle.cs
contains: