Support the nmakeobj path and the standard intermediate output path for compile_commands.json on Windows. #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or compile_commands.json on Windows.
BruceForstall
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Is nmakeObjCompileCommands still here just to support people who haven't updated to the newest (PR'ed) dotnet/runtime? Or do we check both paths for some other reason, like cmake might put things in a different place in some scenarios? it might be helpful to add the answer as comments in the code.
|
Yes, it's just here for backcompat. I'll add a comment in the code. |
jkoritzinsky
commented
Mar 17, 2021
jashook
pushed a commit
to jashook/jitutils
that referenced
this pull request
Mar 8, 2022
…or compile_commands.json on Windows. (dotnet#322)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for dotnet/runtime#49715
cc: @dotnet/jit-contrib for review.