[release/6.0] Support assembly as message origin (#2212) #2220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support assembly as message origin * Add tests * Fix test failures * Add missing file * Update src/linker/Linker.Steps/MarkStep.cs Co-authored-by: Mateo Torres-Ruiz <[email protected]> Co-authored-by: Mateo Torres-Ruiz <[email protected]>
vitek-karas
approved these changes
Aug 20, 2021
jeffschwMSFT
approved these changes
Aug 23, 2021
|
Merging -- we'll review this in the runtime integration PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2213 to release/6.0-rc1
Customer Impact
Linker will crash if types or members with
DynamicallyAccessedMemberTypesare used in assembly attributes.Testing
Unit tests
Risk
Low. The fix allows for the assembly as the source of linker diagnostics, which it didn't before.