Match analyzer and linker requires methods #2788
Conversation
src/ILLink.Shared/DiagnosticId.cs
Outdated
| RequiresDynamicCodeOnStaticConstructor = 3052, | ||
| COMInteropNotSupportedInFullAOT = 3052, |
There was a problem hiding this comment.
Notice that there is a collision on the code IL3052, I don't have a strong preference on which one should remain IL3052 and which one should change, but one should be changed.
There was a problem hiding this comment.
Did we ship one of them in .NET 6? If only one, then we should keep that one as is and change the new one.
If not... I guess just pick one...
There was a problem hiding this comment.
COMInteropNotSupportedInFullAOT in NativeAOT seems to exist even before runtimelab project existed (probably copied from CoreRT), so probably I will leave that as 3052 even if we haven't shipped NativeAOT yet
src/ILLink.Shared/DiagnosticId.cs
Outdated
| RequiresDynamicCodeOnStaticConstructor = 3052, | ||
| COMInteropNotSupportedInFullAOT = 3052, |
There was a problem hiding this comment.
Did we ship one of them in .NET 6? If only one, then we should keep that one as is and change the new one.
If not... I guess just pick one...
Delete non existent ILLink.xsd from projitems
Match analyzer and linker methods that handle Requires to be more similar according to their behavior Delete non existent ILLink.xsd from projitems Fixup IL3052 and add SharedStrings from NativeAOT Commit migrated from dotnet/linker@6aaa900
3 participants
Match analyzer and linker requires methods to be more similar according to their behavior
Sync diagnostic Id in NativeAOT with the information in linker