Fix race condition in build #3185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this change is fixing Mono.Cecil repeated builds, but it does not seem to hurt either. |
marek-safar
approved these changes
Jan 14, 2023
ViktorHofer
approved these changes
Jan 14, 2023
tlakollo
pushed a commit
to tlakollo/runtime
that referenced
this pull request
Jan 16, 2023
Commit migrated from dotnet/linker@4452038
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix a race condition in our build, where Mono.Cecil was being built twice into the same output path. See dotnet/installer#15228 (comment) for context.
Before this change, I saw this line twice in the output:
After this change, I only see it once. I don't understand why
SetTargetFrameworkwas needed in the first place in #1891 (comment), but it no longer seems necessary. Probably the recent changes to the cecil build (arcade onboarding) caused this to become a problem.I have been able to build locally >100 times in a row with this change, without hitting the race, so I think this fixes it. Previously I was seeing it fail about one in ten builds locally.