Turn off supportSparse in GitHubLabeler sample #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input isn't sparse, but the ReadFromTextFile is using the default of supportSparse=true, which is causing the loader to try and fail to parse every row as if it were sparse (you can see this if you hook up an mlcontext.Log handler and print out every message containing "Format").
eerhardt
approved these changes
Feb 15, 2019
|
Questions:
I find this parameter to be "yet another" concept in the "by default" API... In any case, I'm going to take the PR since with current API it is the best approach. 👍 |
stephentoub
added a commit
that referenced
this pull request
Mar 5, 2019
This reverts commit d884cb4.
CESARDELATORRE
pushed a commit
that referenced
this pull request
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input isn't sparse, but the ReadFromTextFile is using the default of
supportSparse=true, which is causing the loader to try and fail to parse
every row as if it were sparse (you can see this if you hook up an
mlcontext.Log handler and print out every message containing "Format").
Related to dotnet/machinelearning#2576
cc: @CESARDELATORRE, @eerhardt