Skip to content

substitute AlignedArray with a regular array #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Anipik opened this issue Sep 25, 2018 · 3 comments
Closed

substitute AlignedArray with a regular array #1018

Anipik opened this issue Sep 25, 2018 · 3 comments
Assignees
Milestone

Comments

@Anipik
Copy link
Contributor

Anipik commented Sep 25, 2018

This issue tracks the progress with removing the aligned array.

The aligned array wont make much difference here as we do a lot of move operation.

More Discussion #383

Rough Implementation :- https://github.com/Anipik/machinelearning/tree/temp

This branch removes all the aligned array code from src as well as implementation. All the tests are passing
Will update the issue with performance numbers soon

cc @danmosemsft @tannergooding @TomFinley @eerhardt

@wschin
Copy link
Member

wschin commented Oct 12, 2018

What kind of perf do you want to have? How large the data sets are being targeted? For large-scale ML, one representative example is training FFM (a user of AlignedArray) on Criteo. Could you give it a try with your changes? Thanks.

@artidoro
Copy link
Contributor

@Anipik was this issue solved with #1274?

@Anipik
Copy link
Contributor Author

Anipik commented Oct 28, 2018

no its yet to be completed

@shauheen shauheen added this to the 1118 milestone Nov 19, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants