Skip to content

SourceLink doesn't work with the Microsoft.ML NuGet package #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eerhardt opened this issue May 9, 2018 · 0 comments · Fixed by #115
Closed

SourceLink doesn't work with the Microsoft.ML NuGet package #103

eerhardt opened this issue May 9, 2018 · 0 comments · Fixed by #115
Assignees
@eerhardt
Labels
Build Build related issue
Milestone
0518

Comments

@eerhardt
Copy link
Member

eerhardt commented May 9, 2018

System information

  • OS version/distro: Windows
  • .NET Version (eg., dotnet --info): net471

Issue

  • What did you do?
    Debug an application that uses Microsoft.ML.
    Load the symbols from the public Microsoft symbols server.
    Try to F11 into new LearningPipeline();.

  • What happened?
    Visual Studio prompted me to find the LearningPipeline.cs file myself.

  • What did you expect?
    I expected Visual Studio to automatically download the file from GitHub for me and step into it.
@eerhardt eerhardt added the Build Build related issue label May 9, 2018
@eerhardt eerhardt self-assigned this May 9, 2018
@shauheen shauheen added this to the 0518 milestone May 9, 2018
eerhardt added a commit to eerhardt/machinelearning that referenced this issue May 9, 2018
@eerhardt
Update NuGet packages to fill out all metadata.
9328cc7 
Also, a minor build change (move property ordering) to fix SourceLink with our packages.

Fix dotnet#43
Fix dotnet#103
eerhardt added a commit to eerhardt/machinelearning that referenced this issue May 10, 2018
@eerhardt
Update NuGet packages to fill out all metadata.
f257d2a 
Also, a minor build change (move property ordering) to fix SourceLink with our packages.

Fix dotnet#43
Fix dotnet#103
@eerhardt eerhardt mentioned this issue May 10, 2018
Merged
shauheen pushed a commit that referenced this issue May 14, 2018
@eerhardt @shauheen
Update NuGet packages to fill out all metadata. (#115)
ca3fca6 
* Update NuGet packages to fill out all metadata.

Also, a minor build change (move property ordering) to fix SourceLink with our packages.

Fix #43
Fix #103

* Adding package icon URL.

* Update Parquet package description.

* Add source code control properties to the NuGet packages.

Also, fix a small bug with the nupkgproj files. The intermediate output folders conflict between the nupkgproj and csproj with the same name. This causes issues because the project.assets.json file is being shared between the two projects, which isn't correct.
eerhardt added a commit to eerhardt/machinelearning that referenced this issue Jul 27, 2018
@eerhardt
Update NuGet packages to fill out all metadata. (dotnet#115)
39d3253 
* Update NuGet packages to fill out all metadata.

Also, a minor build change (move property ordering) to fix SourceLink with our packages.

Fix dotnet#43
Fix dotnet#103

* Adding package icon URL.

* Update Parquet package description.

* Add source code control properties to the NuGet packages.

Also, fix a small bug with the nupkgproj files. The intermediate output folders conflict between the nupkgproj and csproj with the same name. This causes issues because the project.assets.json file is being shared between the two projects, which isn't correct.
@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eerhardt eerhardt

Labels
Build Build related issue
Projects
None yet
Milestone
0518
Development

Successfully merging a pull request may close this issue.

Update NuGet packages to fill out all metadata. eerhardt/machinelearning
2 participants
@shauheen @eerhardt