Skip to content

Regex Number Parsing Errors for netcoreapp 3.0 #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Anipik opened this issue Oct 9, 2018 · 0 comments
Closed

Regex Number Parsing Errors for netcoreapp 3.0 #1199

Anipik opened this issue Oct 9, 2018 · 0 comments

Comments

@Anipik
Copy link
Contributor

Anipik commented Oct 9, 2018

There are two issue that we face while matching the baseline files while running tests for netcoreapp3.0

  • The regex treats -0 and 0 differently. We may need to modify the regex for filtering the numbers to treat -0 and 0 same.
  • Some numbers are in written in the baseline file in the form of exponentials eg 5.011722E-35 They are not picked up by the regex. so while matching these numbers we do an exact match rather than a floating number comparison with some buffer which fails for netcoreapp3.0

cc @danmosemsft @tannergooding @eerhardt @shauheen @codemzs

@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant