-0 parsing corrected and digitsofPrecision added #1320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have queued the build again that the build passed the CI. |
eerhardt
reviewed
Oct 23, 2018
eerhardt
reviewed
Oct 23, 2018
eerhardt
reviewed
Oct 24, 2018
eerhardt
reviewed
Oct 25, 2018
eerhardt
approved these changes
Oct 25, 2018
|
@codemzs @Ivanidzo4ka @TomFinley can somebody take a look at this change. I need one more approval ? |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1199
working towards #1096
This PR corrects about 20 tests by providing the precision numbers as well as parsing the -0 correctly for 3 of the tests
cc @danmosemsft @eerhardt @shauheen @tannergooding