Skip to content

Investigate and deal with the remaining x86 baseline differences #1215

Closed
@tannergooding

Description

@tannergooding

The x86 build of ML.NET has some remaining baseline differences that need investigation and fixing.

From initial investigation, the remaining differences have fewer than 4 matching significant digits and this may be caused by known bugs in the double parsing code (which have already been fixed or are actively being fixed in .NET Core). Other differences are due to the implementation (between x86 and x64) of some floating-point Math functions that the tests depend on.

Activity

tannergooding

tannergooding commented on Oct 10, 2018

@tannergooding
MemberAuthor

The tests disabled for x86 can be identified by: [ConditionalFact(typeof(Environment), nameof(Environment.Is64BitProcess))]. Many of them have an additional comment on the same line of // x86 output differs from Baseline

added
P2Priority of the issue for triage purpose: Needs to be fixed at some point.
on Jan 10, 2020
frank-dong-ms-zz

frank-dong-ms-zz commented on May 6, 2020

@frank-dong-ms-zz
Contributor

Created separate baseline for x86 tests: #5057

Some of the difference from x64 and x86 is due to MKL is generating different results.

ghost locked as resolved and limited conversation to collaborators on Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Priority of the issue for triage purpose: Needs to be fixed at some point.testrelated to tests

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @harishsk@tannergooding@antoniovs1029@frank-dong-ms-zz

        Issue actions

          Investigate and deal with the remaining x86 baseline differences · Issue #1215 · dotnet/machinelearning