Skip to content

Clean up [ConditionalFact(typeof(Environment), nameof(Environment.Is64BitProcess))] #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tannergooding opened this issue Oct 10, 2018 · 1 comment
Labels
up-for-grabs A good issue to fix if you are trying to contribute to the project
Milestone

Comments

@tannergooding
Copy link
Member

It was suggested that creating explicit attributes for the various cases (Such as Onnx, TensorFlow, LightGBM, etc) may be a better long term solution to manage these tests across the various platforms.

See #1008 (comment) for more details.

@danmoseley danmoseley added the up-for-grabs A good issue to fix if you are trying to contribute to the project label Oct 11, 2018
@danmoseley danmoseley changed the title Investigate cleaning up [ConditionalFact(typeof(Environment), nameof(Environment.Is64BitProcess))] Clean up [ConditionalFact(typeof(Environment), nameof(Environment.Is64BitProcess))] Oct 11, 2018
@mareklinka
Copy link
Contributor

mareklinka commented Feb 4, 2019

Hi there. I started looking into this and came up with the following list of attributes that would be necessary:

  1. TensorFlow
  2. Onnx
  3. LightGBM
  4. .NET Core < 3.0 || not Core
  5. MatrixFactorization
  6. Environment = x64 (e.g. where x86 output differs from expected baseline, TestCommandBase:841)
  7. x64 && (.NET Core < 3.0 || not Core)
  8. NotFullFramework

@shauheen shauheen added this to the 0219 milestone Feb 12, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
up-for-grabs A good issue to fix if you are trying to contribute to the project
Projects
None yet
Development

No branches or pull requests

4 participants