Skip to content

MLContext.Model.Save should accept statically typed models too #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Zruty0 opened this issue Oct 17, 2018 · 2 comments
Closed

MLContext.Model.Save should accept statically typed models too #1286

Zruty0 opened this issue Oct 17, 2018 · 2 comments
Labels
enhancement New feature or request up-for-grabs A good issue to fix if you are trying to contribute to the project

Comments

@Zruty0
Copy link
Contributor

Zruty0 commented Oct 17, 2018

Add an extension method in Microsoft.ML.StaticPipe for that
@Zruty0 Zruty0 added enhancement New feature or request up-for-grabs A good issue to fix if you are trying to contribute to the project labels Oct 17, 2018
@Zruty0 Zruty0 mentioned this issue Oct 17, 2018
Merged
llRandom pushed a commit to llRandom/machinelearning that referenced this issue Mar 12, 2019
added an extension method for saving statically typed model (dotnet#1286
ff1abd4 
)
@llRandom llRandom mentioned this issue Mar 12, 2019
Closed
@TomFinley
Copy link
Contributor

TomFinley commented Mar 26, 2019 •
edited
Loading

I'm not altogether certain I agree. My general attitude is that the static API should be confined to things that specifically benefit from static typing of APIs (e.g., discoverability of what transforms can be applied to what data, and suchlike), and that if we enter a world where we don't it's totally acceptable (indeed desirable) to "drop down" to the dynamic API. But this is a more philosophical point, and I view the convenience proposed in this issue as inherently harmless in itself. So I'm not certain I agree, but I don't disagree enough to stand in the way if someone thinks it may be useful.

llRandom pushed a commit to llRandom/machinelearning that referenced this issue Mar 30, 2019
@llRandom
added an extension method for saving statically typed model (dotnet#1286
3e70083 
)
@codemzs
Copy link
Member

codemzs commented Jun 30, 2019

Static API is not being developed on.

@codemzs codemzs closed this as completed Jun 30, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request up-for-grabs A good issue to fix if you are trying to contribute to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added an extension method for saving statically typed model (#1286) llRandom/machinelearning
4 participants
@codemzs @shauheen @TomFinley @Zruty0