Skip to content

Improve constructor for TextLoader #1288

Closed
@Zruty0

Description

@Zruty0

We currently have

public TextLoader(IHostEnvironment env, Column[] columns, Action<Arguments> advancedSettings, IMultiStreamSource dataSample = null)
public TextLoader(IHostEnvironment env, Arguments args, IMultiStreamSource dataSample = null)

We need to:

  1. Make the second constructor internal or private (it's used only by cmdline/dependency injection.
  2. Add 'separator chars' and 'has header' as non-advanced parameters

The first change will naturally trigger a lot of changes in the code that creates the TextLoader, this is by design.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestup-for-grabsA good issue to fix if you are trying to contribute to the project

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions