You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I changed our model format for the ComponentCatalog changes (#970), I refactored some model loading code incorrectly. There are some existing models that are breaking our validation checks:
Contracts.CheckDecode(tail==TailSignatureValue,"Corrupt model file tail");
These checks are now failing with older model files. They were never run in the old code when there were no strings, so we shouldn't be running them anymore when reading older model files.
Older model files are failing to load due to FpTail checks in the model validation code. These checks weren't happening in the old model loading code, and they now fail on some older models.
Fix this by returning early when it is an older model, and there are no strings. This preserves the old behavior.
Fixdotnet#1289
Older model files are failing to load due to FpTail checks in the model validation code. These checks weren't happening in the old model loading code, and they now fail on some older models.
Fix this by returning early when it is an older model, and there are no strings. This preserves the old behavior.
Fixdotnet#1289
* Loading old model files is broken.
Older model files are failing to load due to FpTail checks in the model validation code. These checks weren't happening in the old model loading code, and they now fail on some older models.
Fix this by returning early when it is an older model, and there are no strings. This preserves the old behavior.
Fix#1289
ghost
locked as resolved and limited conversation to collaborators
Mar 27, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When I changed our model format for the ComponentCatalog changes (#970), I refactored some model loading code incorrectly. There are some existing models that are breaking our validation checks:
The old code was doing:
machinelearning/src/Microsoft.ML.Data/Model/ModelHeader.cs
Lines 419 to 424 in 655c2e2
The new code now does:
machinelearning/src/Microsoft.ML.Data/Model/ModelHeader.cs
Lines 482 to 486 in a44e131
Notice that it doesn't return early in the new code. Lower in the method there are checks here:
machinelearning/src/Microsoft.ML.Data/Model/ModelHeader.cs
Lines 538 to 541 in a44e131
These checks are now failing with older model files. They were never run in the old code when there were no strings, so we shouldn't be running them anymore when reading older model files.
/cc @yaeldekel
The text was updated successfully, but these errors were encountered: