Skip to content

Change unit tests to use SelectColumnsTransform instead of ChooseColumnsTransform #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yaeldekel opened this issue Oct 23, 2018 · 0 comments · Fixed by #1371
Closed

Change unit tests to use SelectColumnsTransform instead of ChooseColumnsTransform #1342

yaeldekel opened this issue Oct 23, 2018 · 0 comments · Fixed by #1371
Assignees
@singlis
Labels
API Issues pertaining the friendly API

Comments

@yaeldekel
Copy link

After serialization, ChooseColumnsTransform is deserialized as a SelectColumnsTransform, causing unit tests to fail.

We should also consider changing transforms that use DropColumnsTransform (such as WordHashBag, evaluators etc.) to start using SelectColumnsTransform instead.
singlis added a commit to singlis/machinelearning that referenced this issue Oct 25, 2018
@singlis
Removes ChooseColumnsTransform and DropColumnsTransform classes
c8b5a56 
replacing them with SelectColumnsTransform. These changes include:
* Updates to SelectColumnsTransform to respect ordering when keeping
columns. For example, if the input is ABC and CB is selected, the output
will be CB.
* Updates to code that used Choose or Drop columns, replacing with
SelectColumns.
* Updates to baseline output for tests to pass
* Re-enabled the SavePipeline tests

This fixes dotnet#1342
These changes are also related to dotnet#754
@singlis singlis mentioned this issue Oct 25, 2018
Merged
@artidoro artidoro assigned artidoro and singlis and unassigned artidoro Oct 26, 2018
@artidoro artidoro added the API Issues pertaining the friendly API label Oct 26, 2018
singlis added a commit that referenced this issue Oct 30, 2018
@singlis
Replaces ChooseColumnsTransform and DropColumnsTransform with SelectC…
c2b5e76 
…olumnsTransform (#1371)

* Removes ChooseColumnsTransform and DropColumnsTransform classes
replacing them with SelectColumnsTransform. These changes include:
* Updates to SelectColumnsTransform to respect ordering when keeping
columns. For example, if the input is ABC and CB is selected, the output
will be CB.
* Updates to code that used Choose or Drop columns, replacing with
SelectColumns.
* Updates to baseline output for tests to pass
* Re-enabled the SavePipeline tests

This fixes #1342
These changes are also related to #754
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@singlis singlis

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
No milestone
3 participants
@yaeldekel @artidoro @singlis