-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Final interface of Schema #1500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
API
Issues pertaining the friendly API
Comments
Closed
Hi @Zruty0 thanks for writing this. Pursuant to API review notes, let us consider the following refinements:
|
This was referenced Nov 5, 2018
This was referenced Dec 17, 2018
The only part that remains in this, is cleaning up usages of TryGetColumnIndex; which is not user-facing anymore; and renaming Schema to DataSchema. |
All the work for this is done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As we have agreed on the API reviews, we will make the following modifications to
Schema
:ICollection<Schema.Column>
Column
class to contain 2 fields:IsHidden
andIndex
.this
accessors andGetColumnOrNull
.SchemaBuilder
(in a different namespaceMicrosoft.ML.Schema
) that would be responsible to building the schema.Schema.Metadata.Builder
into a separate classMetadataBuilder
in namespaceMicrosoft.ML.Schema
.DataSchema
The text was updated successfully, but these errors were encountered: