Skip to content

IDataView Cleanup: Rename UInt128 #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TomFinley opened this issue Nov 5, 2018 · 2 comments
Closed

IDataView Cleanup: Rename UInt128 #1534

TomFinley opened this issue Nov 5, 2018 · 2 comments
Assignees
Labels
API Issues pertaining the friendly API
Milestone

Comments

@TomFinley
Copy link
Contributor

The row cursor IDs serve a purpose as described here.

https://github.com/dotnet/machinelearning/blob/master/src/Microsoft.ML.Core/Data/ICursor.md#getidgetter

These IDs are represented as 128-bit numbers. Correspondingly, I named them UInt128 back in the long vanished past. However, this is a troubling name: this first of all conflicts with any name .NET would use in the future to represent 128-bit unsigned integers (assuming they ever did so), which is reason enough not to use it. But even without this reason, this type just doesn't quite act like a number.

On the other hand, I am not certain what a good name would be. Something like RowId, RecordId, or something like that?

/cc @Zruty0 @shauheen @terrajobst

@Zruty0
Copy link
Contributor

Zruty0 commented Nov 12, 2018

I like RowId better. Or even UniqueId.

@TomFinley
Copy link
Contributor Author

I like RowId. UniqueId is bad since they are only probabilistically unique, and people might get confused between that and GUIDs (which go further and are globally unique), which this definitely is not.

@sfilipi sfilipi self-assigned this Dec 11, 2018
@sfilipi sfilipi added this to the 1218 milestone Dec 11, 2018
@sfilipi sfilipi added the API Issues pertaining the friendly API label Dec 11, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API
Projects
None yet
Development

No branches or pull requests

3 participants