Skip to content

Make non-essential members of Core and Data assembly internal #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Zruty0 opened this issue Nov 12, 2018 · 1 comment
Closed

Make non-essential members of Core and Data assembly internal #1602

Zruty0 opened this issue Nov 12, 2018 · 1 comment
Assignees
Milestone

Comments

@Zruty0
Copy link
Contributor

Zruty0 commented Nov 12, 2018

#1519 made it possible to have members that are not public, but still accessible to other ML.NET assemblies. We now plan to use it to reduce the public surface of ML.NET assemblies substantially.

Namely, let's 'hide' the non-user-facing public members of Microsoft.ML.Core assembly

@TomFinley
Copy link
Contributor

In the next few days before we "finalize" the v1.0 RC API surface, we might conceivably hide one or two more things in these assemblies, but the usefulness of "catch-all" issues like this are less useful than they were back in the days when we were hiding hundreds or even thousands of items in our public surface with each PR. For that reason it is probably appropriate to close this issue at this time, since:

  1. the core work it was meant to do has been almost entirely done,

  2. even if it wasn't the opportunity for grand sweeping changes to the API in terms of public surface restriction are limited in the next few days,

  3. and whatever little remains or can be done should have more specific issues.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants