Skip to content

IChannelProvider should become internal #2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Ivanidzo4ka opened this issue Feb 15, 2019 · 3 comments
Closed

IChannelProvider should become internal #2585

Ivanidzo4ka opened this issue Feb 15, 2019 · 3 comments
Labels
API Issues pertaining the friendly API

Comments

@Ivanidzo4ka
Copy link
Contributor

towards #1602
@Ivanidzo4ka Ivanidzo4ka added the API Issues pertaining the friendly API label Feb 15, 2019
@TomFinley
Copy link
Contributor

Unless you have a plan to make IHostEnvironment internal, I don't see how that is possible. Similar comment on your issue #2586.

@Ivanidzo4ka
Copy link
Contributor Author

Do you want to keep IHostEnviroment public?

@TomFinley
Copy link
Contributor

TomFinley commented Feb 16, 2019 •
edited
Loading

Not necessarily. Indeed, if I could wave a magic wand I would indeed make IHostEnvironment internal. Yet at one point it was viewed as inevitable. Do you view such a change as feasible pre-v1? If so, how?

I would also point out that post v1, we have the goal of making component authorship possible. This will not be possible without IHostEnvironment. For that reason, I would focus efforts on making IHostEnvironment palatable, rather than its removal.

Perhaps @eerhardt has some thoughts.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ivanidzo4ka @TomFinley