You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, I couldn't easily remove this copy because doing the copy also changed the VBuffer from float to double. This should also be changed, as recognized by this REVIEW comment in the code:
// REVIEW: Change this, as well as the bin finding code and bin upper bounds, to be Float instead of Double.
This issue is to fix both of these things. First, change BinFinder to work on float instead of double. Then, we can remove this extra copy and just pass in the normal VBuffer<float> to BinFinder, without worrying if it will destroy the buffer.
frank-dong-ms-zz
added
P2
Priority of the issue for triage purpose: Needs to be fixed at some point.
and removed
P1
Priority of the issue for triage purpose: Needs to be fixed soon.
labels
Jun 10, 2020
See the conversation here: #1580 (comment)
With the above change, I made it so the FastTree
BinFinder.FindDistinctCounts
was no longer destructive of thevalues
VBuffer duringCalculateBins
.Now that it no longer destroys the buffer, we no longer need to copy it here:
machinelearning/src/Microsoft.ML.FastTree/FastTree.cs
Lines 1475 to 1478 in cb9effc
However, I couldn't easily remove this copy because doing the copy also changed the VBuffer from
float
todouble
. This should also be changed, as recognized by thisREVIEW
comment in the code:machinelearning/src/Microsoft.ML.FastTree/FastTree.cs
Line 2408 in cb9effc
This issue is to fix both of these things. First, change BinFinder to work on
float
instead ofdouble
. Then, we can remove this extra copy and just pass in the normalVBuffer<float>
toBinFinder
, without worrying if it will destroy the buffer./cc @Zruty0 @TomFinley
The text was updated successfully, but these errors were encountered: